docs(verify): measured perf + a11y pass in verify-frontend (delivery-loop hardening #3)#142
Conversation
|
Warning Review limit reached
Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3dfa192a5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 2. Run `lighthouse_audit` with the **accessibility** + **performance** + | ||
| **best-practices** categories. |
There was a problem hiding this comment.
When an agent follows Step 2.5 for any UI route, this asks lighthouse_audit for a performance category and then scores CLS/LCP from that pass. The Chrome DevTools MCP tool reference says lighthouse_audit “excludes performance” and directs performance audits to performance_start_trace, so this mandatory verification either fails at invocation or silently misses the Web Vitals budget it claims to enforce.
Useful? React with 👍 / 👎.
…loop hardening #3) Add Step 2.5 to the dikw-web-verify-frontend skill: run the already-installed chrome-devtools-mcp lighthouse_audit (accessibility + performance + best-practices) against the changed route, scored to a rubric (a11y >= 0.9 with no new violation, CLS <= 0.1, LCP recorded). Turns the eyeballed ui-checklist a11y/contrast/perf items into measured numbers, per Delba Oliveira's feedback-loops note. Locally-measured, not a new CI gate. Updates ui-checklist.md, CLAUDE.md delivery step 5, ADR 0005.
helebest
force-pushed
the
ci/perf-a11y-verify
branch
from
b3dfa19 to
7dfe76f
Compare
|
Good catch — valid. Fixed in |
1 participant
What
Adds Step 2.5 — Measured perf + a11y to the
dikw-web-verify-frontendskill. The skill verified real-browser behavior + a clean console, then eyeballed thedocs/ui-checklist.mdaccessibility / contrast / perf items. Now it runs the already-installedchrome-devtools-mcplighthouse_audit(accessibility + performance + best-practices) against the changed route, scored to a rubric:mainperf.spec.tsgate; the trace shows which element shifted)Why
This is item #3 of the delivery-loop hardening effort (
docs/adr/0005-delivery-loop-hardening.md), implementing Delba Oliveira's point that "many checks have criteria Claude can measure against: a performance budget, an accessibility checklist." It turns qualitative rubric items into numbers. Kept locally-measured, not a new CI gate — Lighthouse timing is runner-dependent (the same reasonperf.spec.tshard-gates only CLS). The#graphPixi route audits a11y normally but skips the background-tab perf trace (stalledrequestAnimationFrame), mirroring the skill's existing Chrome-MCP caveat.Scope
Docs/skill only —
dikw-web-verify-frontend/SKILL.md,docs/ui-checklist.md,CLAUDE.md(delivery step 5),docs/adr/0005, CHANGELOG, version. Nosrc/server/test/runtime code.npm run check:gatepasses with no label (touches no verification machinery).🤖 Generated with Claude Code